[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 20/23] fix parameter to firmware calls
|
From: |
Andrey Borzenkov |
|
Subject: |
Re: [RFC PATCH 20/23] fix parameter to firmware calls |
|
Date: |
Wed, 2 Apr 2014 21:16:48 +0400 |
В Wed, 2 Apr 2014 10:08:32 -0700
Ram Pai <address@hidden> пишет:
> On Tue, Apr 01, 2014 at 09:45:35PM +0400, Andrey Borzenkov wrote:
> > В Wed, 26 Feb 2014 10:31:19 -0800
> > Ram Pai <address@hidden> пишет:
> >
> > > -#define IEEE1275_ADDR(x) (grub_uint32_t)(grub_addr_t)(x)
> > > -
> > > +#define IEEE1275_ADDR(x)
> > > (grub_uint32_t)grub_cpu_to_be32((grub_addr_t)(x))
> > > +#define IEEE1275_VALUE(x) (grub_uint32_t)grub_cpu_to_be32(x)
> >
> > Same question - what about sparc64, is it safe to truncate values there?
>
> dont know anything about sparc64. Probably not.
>
> These macros are used only for the powerpc specific code AFAICT.
Files under grub-core/*/ieee1275 are used for ieee1275 platforms, which
include sparc64 (and actually i385 as well, so you need to check how it
affects these too)
GROUPS["ieee1275"] = [ "i386_ieee1275", "sparc64_ieee1275",
"powerpc_ieee1275" ]
> I will audit and confirm.
>
>