[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [RFC PATCH 20/23] fix parameter to firmware calls
|
From: |
Ram Pai |
|
Subject: |
Re: [RFC PATCH 20/23] fix parameter to firmware calls |
|
Date: |
Wed, 2 Apr 2014 10:08:32 -0700 |
|
User-agent: |
Mutt/1.5.20 (2009-12-10) |
On Tue, Apr 01, 2014 at 09:45:35PM +0400, Andrey Borzenkov wrote:
> В Wed, 26 Feb 2014 10:31:19 -0800
> Ram Pai <address@hidden> пишет:
>
> > -#define IEEE1275_ADDR(x) (grub_uint32_t)(grub_addr_t)(x)
> > -
> > +#define IEEE1275_ADDR(x)
> > (grub_uint32_t)grub_cpu_to_be32((grub_addr_t)(x))
> > +#define IEEE1275_VALUE(x) (grub_uint32_t)grub_cpu_to_be32(x)
>
> Same question - what about sparc64, is it safe to truncate values there?
dont know anything about sparc64. Probably not.
These macros are used only for the powerpc specific code AFAICT. I will audit
and confirm.
--
Ram Pai