Re: [RFC PATCH 21/23] powerpc64 is not necessarily BigEndian anymore! :)

[Andrey Borzenkov]

В Wed, 26 Feb 2014 10:31:20 -0800
Ram Pai <address@hidden> пишет:

> From: Anton Blanchard <address@hidden>
> 
>  powerpc64 is not necessarily BigEndian anymore! :)
> 
> Signed-off-by: Ram Pai <address@hidden>
> ---
>  include/grub/powerpc/types.h | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> diff --git a/include/grub/powerpc/types.h b/include/grub/powerpc/types.h
> index 7a2fc6b..ab138d4 100644
> --- a/include/grub/powerpc/types.h
> +++ b/include/grub/powerpc/types.h
> @@ -19,7 +19,7 @@
>  #ifndef GRUB_TYPES_CPU_HEADER
>  #define GRUB_TYPES_CPU_HEADER        1
>  
> -#ifdef __powerpc64le__
> +#ifdef __powerpc64__
>  /* The size of void *.  */
>  #define GRUB_TARGET_SIZEOF_VOID_P    8
>  
> @@ -33,8 +33,12 @@
>  #define GRUB_TARGET_SIZEOF_LONG              4
>  #endif
>  
> -/* powerpc is big-endian.  */
> -#define GRUB_TARGET_WORDS_BIGENDIAN  1
> +#ifdef __powerpc64le__
> +#undef GRUB_TARGET_WORDS_BIGENDIAN
> +#else
> +#define GRUB_TARGET_WORDS_BIGENDIAN     1
> +#endif
> +

For the sake of bisectability this really should be moved earlier;
otherwise at least patch "fix parameter to firmware calls" would
be wrong.

>  
>  
>  #endif /* ! GRUB_TYPES_CPU_HEADER */