grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: please attempt to minimize string changes


From: Vladimir 'φ-coder/phcoder' Serbinenko
Subject: Re: please attempt to minimize string changes
Date: Sun, 22 Dec 2013 16:18:10 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10

On 22.12.2013 10:18, Benno Schulenberg wrote:
> 
> On Sun, Dec 22, 2013, at 5:55, Andrey Borzenkov wrote:
>> Will below patch help? It also removes trailing dot on the first
>> paragraph which was not present before.
> 
> Thanks, the patch looks good.  Except that the trailing dot needs
> to be there: it is a doc string and should end in a period.  The
> addition of the dot was an improvement.  :)
> 
@Andrey. Could you commit your patch with this suggestion?
Thanks
> The general rule is: when the string starts with a capitalized word,
> it wants to be a full sentence and should end in a period.  When the
> message starts with a lowercase letter, don't use a period anywhere
> in the message; when you need a second sentence, use a semicolon.
> 
>> I usually use [TERMINAL ...] (with extra spaces). I find it established
>> enough practice at least in UNIX manuals.
> 
> Indeed.  Although in most of the man pages I've looked at just now
> (df, ls, grep, sed, swapon, gawk), only gawk uses a space before the
> dots.  But whatever you choose, please make it consistent across
> grub -- I've seen at least one instance without a space before the
> dots in grub's messages.
> 
> Regards,
> 
> Benno
> 


Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]