Re: [PATCH] spaces (label, UUID)

[Carles Pina i Estany]

Hi,

On Jan/01/2010, Robert Millan wrote:
> On Mon, Dec 28, 2009 at 02:17:37AM +0100, Carles Pina i Estany wrote:
> > === modified file 'normal/misc.c'
> > --- normal/misc.c   2009-12-20 23:32:15 +0000
> > +++ normal/misc.c   2009-12-28 01:15:34 +0000
> > @@ -68,7 +68,10 @@ grub_normal_print_device_info (const cha
> >           if (grub_errno == GRUB_ERR_NONE)
> >             {
> >               if (label && grub_strlen (label))
> > -               grub_printf_ (N_("- Label %s"), label);
> > +               {
> > +                 grub_putchar (' ');
> > +                 grub_printf_ (N_("- Label \"%s\""), label);
> > +               }

> Why not just add a space before the -?
> 
> Uhm, I guess I know the answer in advance :-)

I think that you thought about half of the reasons :-)

> Carles, we shouldn't avoid changing translatable strings at the cost
> of making the code bigger or less efficient.  It's not hard for
> translators to reuse the old string.

This is half of the reason (and not too bad: this translation will
appear as "fuzzy" so it's not everything lost)

The other reason:
http://lists.gnu.org/archive/html/grub-devel/2009-12/msg00131.html

Avoiding to have trailing spaces helps the translators (they will do
less mistakes).

Of course makes the code slightly bigger (source code and binary)

> I notice that you committed it already.  Please can you adjust?

Yes I can adjust, but could you reconfirm if I should adjust after above
message?

Thanks,

-- 
Carles Pina i Estany
        http://pinux.info