grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: gettextize normal/menu_text.c (print_timeout)


From: Carles Pina i Estany
Subject: Re: gettextize normal/menu_text.c (print_timeout)
Date: Wed, 25 Nov 2009 00:30:59 +0000
User-agent: Mutt/1.5.20 (2009-06-14)

Hi,

On Nov/25/2009, Carles Pina i Estany wrote:
> 
> Hi,
> 
> > > +  const char *msg_localized = _("   The highlighted entry will be booted 
> > > automatically in %ds.");
> > > +  const int msg_localized_len = grub_strlen (msg_localized);
> > > +  const int number_spaces = GRUB_TERM_WIDTH - msg_localized_len;
> > 
> > Seems like the right approach.  I wonder if we should do something
> > about the preceding spaces too...
> 
> find attached a patch that gettextizes menu_text.c

now yes, attached

BTW, I left spaces on the left of lot of strings. In my opinion I would
delete it and call print_spaces(3);. Fine? (or call grub_printf ("   ");
).

I removed the \n from the end of strings and used grub_putchar ('\n');
or grub_printf ("\n\n"); to not bother the translators and reuse the
strings.

-- 
Carles Pina i Estany
        http://pinux.info

Attachment: gettext_menu_text.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]