grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iso9660 UUID support by using the creation date/time


From: Felix Zielcke
Subject: Re: [PATCH] iso9660 UUID support by using the creation date/time
Date: Sun, 31 Aug 2008 19:23:41 +0200

Am Sonntag, den 31.08.2008, 18:56 +0200 schrieb Robert Millan:
> Some more things I overlooked..

> > +}__attribute__ ((packed));
>     ^
> 
> Please add a space here

Right.

> > @@ -812,8 +826,59 @@ grub_iso9660_label (grub_device_t device
> >    return grub_errno;
> >  }
> >  
> > -
> 
> Please don't remove the ^Ls.

It was moved to down, but I forgot an empty line so diff choose to - and + it.
Fixed now in the attached one it's only once shown now without - or + :)

Bean hopefully comments on this too because he did the iso9660 module.
I leaved now the errno to BAD_NUMBER.
 
-- 
Felix Zielcke

Attachment: iso9660_uuid.patch.4
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]