grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] iso9660 UUID support by using the creation date/time


From: Robert Millan
Subject: Re: [PATCH] iso9660 UUID support by using the creation date/time
Date: Sun, 31 Aug 2008 18:56:47 +0200
User-agent: Mutt/1.5.13 (2006-08-11)

Some more things I overlooked..

On Sun, Aug 31, 2008 at 04:27:04PM +0200, Felix Zielcke wrote:
> +struct grub_iso9660_date
> +{
> +  grub_uint8_t year[4];
> +  grub_uint8_t month[2];
> +  grub_uint8_t day[2];
> +  grub_uint8_t hour[2];
> +  grub_uint8_t minute[2];
> +  grub_uint8_t second[2];
> +  grub_uint8_t hundredth[2];
> +  grub_uint8_t offset;
> +}__attribute__ ((packed));
    ^

Please add a space here

> @@ -812,8 +826,59 @@ grub_iso9660_label (grub_device_t device
>    return grub_errno;
>  }
>  
> -

Please don't remove the ^Ls.
 
-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."




reply via email to

[Prev in Thread] Current Thread [Next in Thread]