[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] iso9660 UUID support by using the creation date/time
From: |
Felix Zielcke |
Subject: |
Re: [PATCH] iso9660 UUID support by using the creation date/time |
Date: |
Sun, 31 Aug 2008 20:55:38 +0200 |
Am Sonntag, den 31.08.2008, 20:40 +0200 schrieb Robert Millan:
> On Sun, Aug 31, 2008 at 07:23:41PM +0200, Felix Zielcke wrote:
> > + *uuid = grub_malloc (sizeof ("YYYY-MM-DD-HH-mm-ss-hh")
>
> Lovely :-)
>
> > + sizeof ('\0'));
>
> Is this really needed? sizeof("foo") implicitly includes the trailing \0.
Args, I'm blind :(
I copied the function from fs/ntfs.c and there it says `grub_malloc 16 + sizeof
(\0)'
With "" it's useless so .5 attached so it doestn't get lost :)
--
Felix Zielcke
iso9660_uuid.patch.5
Description: Text document