Re: [PATCH] Replace magic numbers by constants

[Marco Gerards]

Hi,

Carles Pina i Estany <address@hidden> writes:

> When I did the Home/End keys patch I noticied that in normal/menu.c
> there was some magic numbers (and some constants was already defined, in
> include/grub/term.h (actually, reading the ChangeLog was committed by
> Robert Millan on 2008-02-05)
>
> I'm sending a patch to change the magic numbers by constants.
>
> ChangeLog:
> --------
> 2008-08-17  Carles Pina i Estany  <address@hidden>
>
>       * menu/normal.c (run_menu): Change magic numbers by constants.

Can you be more specific about what you replace?

Thanks,
Marco