Re: [PATCH] Replace magic numbers by constants

[Carles Pina i Estany]

Hello,

On Aug/17/2008, Robert Millan wrote:
> On Sun, Aug 17, 2008 at 04:29:16PM +0200, Carles Pina i Estany wrote:
> > 2008-08-17  Carles Pina i Estany  <address@hidden>
> > 
> >         * menu/normal.c (run_menu): Change magic numbers by constants
> >     (16 by GRUB_TERM_UP and 14 by GRUB_TERM_DOWN)
> 
> When reading the subject I thought it was the other way around.  Would
> something like:
> 
>   "replace hardcoded numbers with macros"
> 
> or
> 
>   "macroify numbers"

Ok:

--------
2008-08-17  Carles Pina i Estany  <address@hidden>

        * menu/normal.c (run_menu): Replace hardcoded numbers with macros
        (16 for GRUB_TERM_UP and 14 for GRUB_TERM_DOWN)
--------

> etc, make it more clear?

An English note: In my previous mail I've confused "change ... by" 
with "change ... for" :-)

Thanks,

-- 
Carles Pina i Estany            GPG id: 0x17756391
        http://pinux.info