[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Replace magic numbers by constants
|
From: |
Carles Pina i Estany |
|
Subject: |
Re: [PATCH] Replace magic numbers by constants |
|
Date: |
Sun, 17 Aug 2008 16:29:16 +0200 |
|
User-agent: |
Mutt/1.5.18 (2008-05-17) |
Hi,
On Aug/17/2008, Marco Gerards wrote:
> Hi,
>
> Carles Pina i Estany <address@hidden> writes:
>
> > When I did the Home/End keys patch I noticied that in normal/menu.c
> > there was some magic numbers (and some constants was already defined, in
> > include/grub/term.h (actually, reading the ChangeLog was committed by
> > Robert Millan on 2008-02-05)
> >
> > I'm sending a patch to change the magic numbers by constants.
> >
> > ChangeLog:
> > --------
> > 2008-08-17 Carles Pina i Estany <address@hidden>
> >
> > * menu/normal.c (run_menu): Change magic numbers by constants.
>
> Can you be more specific about what you replace?
sure:
--------
2008-08-17 Carles Pina i Estany <address@hidden>
* menu/normal.c (run_menu): Change magic numbers by constants
(16 by GRUB_TERM_UP and 14 by GRUB_TERM_DOWN)
--------
--
Carles Pina i Estany GPG id: 0x17756391
http://pinux.info
- [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants, Marco Gerards, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants,
Carles Pina i Estany <=
- Re: [PATCH] Replace magic numbers by constants, Robert Millan, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/17
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/20
- Re: [PATCH] Replace magic numbers by constants, Robert Millan, 2008/08/20
- Re: [PATCH] Replace magic numbers by constants, Carles Pina i Estany, 2008/08/20