grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: embedding filesystems in core image (Re: moving ata initialisation t


From: Robert Millan
Subject: Re: embedding filesystems in core image (Re: moving ata initialisation to a command)
Date: Sat, 22 Dec 2007 13:18:27 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

Here's a new patch, with some cleanup.  The main difference is that memdisk.c
doesn't include any arch-specific code.

I've spotted a memory management problem.  The memdisk image, at the location
that it's usually uncompressed, tends to collide with the payload loading
region (grub_os_area_{addr,size}).

I'm not sure what would be a good solution to this.  Perhaps we could copy it
to dynamic memory in grub_memdisk_init() ?  However, if user plays with payload
images without booting them, and then loads memdisk.mod manually, things could
break.

Although, embedding a memdisk image without embedding memdisk.mod is kind of
silly;  perhaps grub-mkimage shouldn't allow it.

What do you think?

-- 
Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]