Re: [PATCH] Add host open devicename check

[Marco Gerards]

Robert Millan <address@hidden> writes:

> On Fri, Nov 09, 2007 at 10:17:19PM +0100, Marco Gerards wrote:
>> Robert Millan <address@hidden> writes:
>> 
>> > On Thu, Oct 25, 2007 at 09:51:38PM +0200, Christian Franke wrote:
>> >>  static grub_err_t
>> >> -grub_host_open (const char *name __attribute((unused)), grub_disk_t disk)
>> >> +grub_host_open (const char *name, grub_disk_t disk)
>> >>  {
>> >> +  if (grub_strcmp(name, "host"))
>> >> +      return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "not a host disk");
>> >> +
>> >
>> > I would test for (disk->id == GRUB_DISK_DEVICE_HOST_ID) instead.  Faster,
>> > and also cleaner/simpler IMHO.
>> 
>> It's not possible unfortunately :-(.  This information is about to be
>> filled in in this same function.
>
> Still seems like an ugly hack to me.  Oh well :-/

It isn't.  The driver gets a string that it can use to determine if it
has control over this disk or not.  `grub_disk_t disk' is there to be
filled in if it has, it isn't initialised yet.

--
Marco