[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Add host open devicename check

From: Robert Millan
Subject: Re: [PATCH] Add host open devicename check
Date: Fri, 9 Nov 2007 21:56:38 +0100
User-agent: Mutt/1.5.13 (2006-08-11)

On Thu, Oct 25, 2007 at 09:51:38PM +0200, Christian Franke wrote:
>  static grub_err_t
> -grub_host_open (const char *name __attribute((unused)), grub_disk_t disk)
> +grub_host_open (const char *name, grub_disk_t disk)
>  {
> +  if (grub_strcmp(name, "host"))
> +      return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "not a host disk");
> +

I would test for (disk->id == GRUB_DISK_DEVICE_HOST_ID) instead.  Faster,
and also cleaner/simpler IMHO.

Robert Millan

<GPLv2> I know my rights; I want my phone call!
<DRM> What use is a phone call, if you are unable to speak?
(as seen on /.)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]