Re: [PATCH] Add host open devicename check

[Marco Gerards]

Christian Franke <address@hidden> writes:

> Marco Gerards wrote:
>>> ..
>>>
>>> 2007-10-25  Christian Franke  <address@hidden>
>>>
>>>     * disk/host.c (grub_host_open): Add check for "host". This fixes
>>>     the problem that grub-emu does not find partitions.
>>>
>>
>> Please mention the attribute change.
>>
>>
>>> ...
>>>  static grub_err_t
>>> -grub_host_open (const char *name __attribute((unused)), grub_disk_t disk)
>>> +grub_host_open (const char *name, grub_disk_t disk)
>>>  {
>>> +  if (grub_strcmp(name, "host"))
>>> +      return grub_error (GRUB_ERR_UNKNOWN_DEVICE, "not a host disk");
>>>
>>
>> Please add a space after the function name and before the "(".
>>
>>
>
> Done
>
> Christian
>
> 2007-11-10  Christian Franke  <address@hidden>
>
>       * disk/host.c (grub_host_open): Remove attribute unused from
>       name parameter. Add check for "host". This fixes the problem
>       that grub-emu does not find partitions.

Looks fine to me.

--
Marco