Re: [Groff] Automake migration proposal

[Ingo Schwarze]

Hi Bertrand,

here is one other small bug in the automake branch.

With the old build system, "make dist" puts the file
"groff-1.22.2/doc/gnu.eps" into the tarball.  When running "make
dist" from the automake branch, that file is missing from the
tarball.

Consequently, even if you have run "./configure" with the arguments
"pnmtops=missing", the following is run during the build:

xpmtoppm ./doc/gnu.xpm | pnmdepth 15 | pnmtops -noturn -rle > gnu.eps

That is due to the following unguarded rule in Makefile.am:

# File used by contrib/hdtbl and contrib/pdfmark
gnu.eps:
        if test -f $(top_srcdir)/doc/gnu.eps; then \
          cp $(top_srcdir)/doc/gnu.eps . ; \
        elif test -f $(top_builddir)/doc/gnu.eps; then \
          cp $(top_builddir)/doc/gnu.eps . ; \
        else \
          xpmtoppm $(top_srcdir)/doc/gnu.xpm | pnmdepth 15 \
            | $(pnmtops_nosetpage) -noturn -rle >$@ ; \
        fi

The easiest fix probably is to make sure that "make dist"
puts gnu.eps into the distribution tarball.


Besides, the following makes no sense to me.
My build log first says:

  checking for pnmtops... missing

And then, a few lines later:

  checking whether pnmtops can handle the -nosetpage option... yes

Sure, i do have pnmtops installed (because i need it sometimes for
non-groff purposes) but i must not use it in our groff package build
(because groff is a build dependency for more than 1000 other
packages and hence isn't allowwd to have build dependencies itself,
in particular, cannot depend on netpbm).

The problem appears to be that configure.ac unconditionally
calls "GROFF_PNMTOPS_NOSETPAGE" even if the "GROFF_PDFDOC_PROGRAMS"
right before returned "missing".  Probably a conditional is
missing there in configure.ac or something...

Yours,
  Ingo