groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] Automake migration proposal


From: Bertrand Garrigues
Subject: Re: [Groff] Automake migration proposal
Date: Wed, 13 Aug 2014 20:16:52 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)

Werner,
On Wed, Aug 13 2014 at 09:47:32 AM, Werner LEMBERG <address@hidden> wrote:
>> I'm not sure if it would be easy to split the patch, you could not
>> really check the intermediate states if you can't compile.
>
> This doesn't matter!  The most important thing is to split the patch
> into smaller, *logical* chunks that can be easily understood.
>
>> I think the easiest way to review the build system is the compare
>> every .am file with the original Makefile.sub.
>
> Well, yes, but it could be helpful to handle, say, the various make
> targets in different commits.

OK, I can make a new branch a split the single big commit into smaller
ones. It should even be possible to keep the compilation working by
starting with the parts that have no dependency (utils, preproc). I
propose - roughly - the following split (that's more or less the order
in which I have made my development):

  - gnulib + arch + src/include + src/libs + and of course top-level
    Makefile.am
  - src/utils
  - src/preproc
  - src/devices
  - src/roff
  - font
  - tmac
  - contrib
  - man
  - doc

And for each part I can split the work with 3 or 4 commits: build OK,
install OK, clean OK, dist OK. In some cases there would be only one
step because automake generates everything that is needed to manage
these 4 targets.

This should split the commit into, maybe, 30 commits.

Is it OK for you ?

Regards,

--
Bertrand Garrigues



reply via email to

[Prev in Thread] Current Thread [Next in Thread]