groff
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Groff] Patch for two grohtml bug fixes..


From: Ralph Corderoy
Subject: Re: [Groff] Patch for two grohtml bug fixes..
Date: Mon, 08 Oct 2001 23:14:01 +0100

Hi Gaius,

> Also modified is the constant 65535 to MAX_COLOR_VAL, for what it is
> worth.. :-)
> 
> ...
> 
> -  if (val > 65536) {
> +  if (val > color::MAX_COLOR_VAL) {
>      warning(WARN_RANGE, "%1 cannot be greater than 1", color);
> -    return 65535;      // this is 0xffff
> +    return color::MAX_COLOR_VAL;

The two constants replaced by color::MAX_COLOR_VAL are different.  This
looks OK because the old code looked `out by one' but I thought it
worth raising to make sure as I haven't looked at the code at all, just
the diff.

Cheers,


Ralph.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]