[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [GNUnet-developers] Human redable filesizes for gnunet-gtk

From: Christian Grothoff
Subject: Re: [GNUnet-developers] Human redable filesizes for gnunet-gtk
Date: Sun, 23 Apr 2006 15:49:52 -0700
User-agent: KMail/1.9.1

I see a few minor problems:
a) memory leak -- you need to free the string (in namespace)
b) to free properly with "FREE", you ought to use our internal STRDUP/MALLOC
    instead of glib's (since we might do some extra stuff to the pointers)
c) you removed the old (integer) size field -- we should keep it around to
    make sorting (once we add that) easier
d) you only set the xalign property once, why?

Otherwise, looks good.  


On Sunday 23 April 2006 08:36, Milan wrote:
> Hi all !
> I made a little patch (rare project I managed to realize ;-) ) to show
> smart sizes in gnunet-gtk :  "10 MiB" instead of "10485760".
> It's made of a little function in helper.c, which is used 3 times, from
> search.c, download.c and namespace.c. Patch is attached.
> I also changed the title of columns in the Advanced panel to "Name" and
> "Size" instead of "Filename" and "Filesize", for consistency with other
> panels (downloads and search). Hope this is good...
> Christian, could you commit the patch to SVN ? Please tell me if there's
> any problem.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]