Re: [PATCH] make test: Make failure results more verbose

[Max Nikulin]

On 02/01/2022 20:12, Ihor Radchenko wrote:
> In newer Emacs, ERT is capable of providing more info about FAILED
> tests. Maybe we can enable this option by default in the Org test suite?

I like you attempts to make tests better.

Ihor, are there examples of new error reports in mail lists, blogs, etc? 
I am not motivated enough to try development version of emacs, but my 
impression that current error log looks like rectangles of garbage.

In my opinion, code of test should be written having clear error reports 
in mind.

> +BTEST_ERT_VERBOSE = yes

I am unsure if this line or local.mk has priority. I am unsure the the 
following is better as well.

BTEST_ERT_VERBOSE ?= yes

Is there an easy way to limit number of failures before termination of 
tests in the case of verbose reporting? It should prevent test log from 
blowing too much. Usually there is no point in all details if all or 
even 1/4 of tests fails.

> +       TMPDIR=$(testdir) EMACS_TEST_VERBOSE=yes $(BTEST)

A purist would say that it is not a directory, it is something like 
...FLAGS or ...ARGS. I know, it was abused before your patch.

Shouldn't it be mentioned in testing/README?