emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] make test: Make failure results more verbose


From: Ihor Radchenko
Subject: [PATCH] make test: Make failure results more verbose
Date: Sun, 02 Jan 2022 21:12:59 +0800

Hi,

In newer Emacs, ERT is capable of providing more info about FAILED
tests. Maybe we can enable this option by default in the Org test suite?

Best,
Ihor

>From 5e78a588a73871e54177080b3a6c9667f97500be Mon Sep 17 00:00:00 2001
Message-Id: 
<5e78a588a73871e54177080b3a6c9667f97500be.1641129033.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Sun, 2 Jan 2022 21:08:11 +0800
Subject: [PATCH] make test: Make failure results more verbose

* mk/default.mk: New option BTEST_ERT_VERBOSE controlling verbosity of
ERT results.  The new default is verbose.
* mk/targets.mk (check test test-dirty): Obey BTEST_ERT_VERBOSE

Starting from
https://git.savannah.gnu.org/cgit/emacs.git/commit/etc/NEWS?id=8be9d4a1568c34aed753b085d5d33daef5dfa797
ERT can output more verbose failure results.  More verbose sounds like
a better default.
---
 mk/default.mk | 2 ++
 mk/targets.mk | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/mk/default.mk b/mk/default.mk
index c8a15bdd2..c49950c04 100644
--- a/mk/default.mk
+++ b/mk/default.mk
@@ -32,6 +32,8 @@ TMPDIR ?= /tmp
 testdir = $(TMPDIR)/tmp-orgtest
 
 # Configuration for testing
+# setup ERT vebosity
+BTEST_ERT_VERBOSE = yes
 # add options before standard load-path
 BTEST_PRE   =
 # add options after standard load path
diff --git a/mk/targets.mk b/mk/targets.mk
index 6de77b1e6..937bb82bc 100644
--- a/mk/targets.mk
+++ b/mk/targets.mk
@@ -103,7 +103,11 @@ vanilla:
 check test::   compile
 check test test-dirty::
        -$(MKDIR) $(testdir)
+ifeq ($(BTEST_ERT_VERBOSE),yes)
+       TMPDIR=$(testdir) EMACS_TEST_VERBOSE=yes $(BTEST)
+else
        TMPDIR=$(testdir) $(BTEST)
+endif
 ifeq ($(TEST_NO_AUTOCLEAN),) # define this variable to leave $(testdir) around 
for inspection
        $(MAKE) cleantest
 endif
-- 
2.34.1


reply via email to

[Prev in Thread] Current Thread [Next in Thread]