[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape fo

From: Matthew MacLean
Subject: Re: [O] fa5fd6351605912ec75e783cb62649 breaks org-babel-script-escape for ob-ruby
Date: Tue, 11 Aug 2015 21:24:13 -0600

If the stricter definition covers everything that org-babel-escape-script was supposed to do... I agree we should keep it.
My problem was I wasn't sure if the function got pruned of something it needed.

But if that's not the case...

On Tue, Aug 11, 2015 at 6:52 PM, Kyle Meyer <address@hidden> wrote:
Feel free to wait to hear others' thoughts on this, but, in any case,
please use 'git format-patch' to generate a patch with a commit message
(see the contributing section of the website [1] for more information).
Also, it'd be nice to add a test that catches the original error.

...here is the git format-patch of the ob-ruby.el change!

I also created one for a test to check for basic Ruby evaluation capabilities. It should catch errors that break evaluation like this in ob-ruby. (I find it interesting that the session tests worked without the double-escape change actually.)

Attachment: 0001-Removed-double-escape-in-ob-ruby.el-In-org-babel-rub.patch
Description: Text Data

Attachment: 0002-Add-test-that-basic-Ruby-evaluation-works-with-ob-ru.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]