emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [O] [PATCH 2/2] Orgpan: quiet byte-compiler


From: Bastien
Subject: Re: [O] [PATCH 2/2] Orgpan: quiet byte-compiler
Date: Sat, 22 Dec 2012 16:13:20 +0100
User-agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3.50 (gnu/linux)

Hi Jonas,

Jonas Bernoulli <address@hidden> writes:

> * contrib/lisp/org-panel.el: don't setq undefined and otherwise unused
>   variable orgpan-this-panel-window
> * contrib/lisp/org-panel.el (orgpan-check-panel-mode): fix format
>   string of (error)
> * contrib/lisp/org-panel.el: declare variables
>   viper-emacs-state-mode-list and viper-new-major-mode-buffer-list
>   which are defined in viper.el
>
> TINYCHANGE

Applied to master, thanks.

PS: Commit changelogs should use proper sentences: uppercase letter at
the beginning, full-stop at the end, two spaces between sentences.  Not
that a problem for commits that go into contrib/, but important for 
those going into Org's core.  Thanks for thinking of it!

Also, I added you to the list of FSF-signed contributors on Worg:
http://orgmode.org/worg/org-contribute.html#contributors_with_fsf_papers

-- 
 Bastien



reply via email to

[Prev in Thread] Current Thread [Next in Thread]