emacs-orgmode
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Orgmode] Bug: org-store-link only works interactively [7.4]


From: Dave Abrahams
Subject: [Orgmode] Bug: org-store-link only works interactively [7.4]
Date: Sun, 19 Dec 2010 23:51:59 -0900
User-agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (Gojō) APEL/10.8 Emacs/23.2 (x86_64-apple-darwin) MULE/6.0 (HANACHIRUSATO)


Remember to cover the basics, that is, what you expected to happen and
what in fact did happen.  You don't know how to make a good report?  See

     http://orgmode.org/manual/Feedback.html#Feedback

Your bug report will be posted to the Org-mode mailing list.
------------------------------------------------------------------------

Because of this stanza at the end of org-store-link:

    (if (and (or (interactive-p) executing-kbd-macro) link)
        (progn
          (setq org-stored-links
                (cons (list link desc) org-stored-links))
          (message "Stored: %s" (or desc link))
          (when custom-id
            (setq link (concat "file:" (abbreviate-file-name (buffer-file-name))
                               "::#" custom-id))
            (setq org-stored-links
                  (cons (list link desc) org-stored-links))))
      (or agenda-link (and link (org-make-link-string link desc))))))

org-stored-links will only be updated if the function is called
interactively.  I'm not sure why you would want to neuter
org-store-link otherwise, but the docs for interactive-p say:

  The only known proper use of `interactive-p' is in deciding whether to
  display a helpful message, or how to display it.  If you're thinking
  of using it for any other purpose, it is quite likely that you're
  making a mistake.  

Granted, it also says:

  Think: what do you want to do when the command is called from a
  keyboard macro?

and you handle that particular case explicitly.  However, there are
other reasons not to write functions this way (namely, someone like me
will want to store a link programmatically, and will then have to
spend a long time debugging to discover why it doesn't work).

Emacs  : GNU Emacs 23.2.1 (x86_64-apple-darwin, NS apple-appkit-1038.29)
 of 2010-05-08 on black.local
Package: Org-mode version 7.4

-- 
Dave Abrahams
BoostPro Computing
http://www.boostpro.com




reply via email to

[Prev in Thread] Current Thread [Next in Thread]