[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/buttercup a91f282 283/340: Handle multiline spec descripti
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/buttercup a91f282 283/340: Handle multiline spec descriptions in buttercup-reporter-batch-color |
Date: |
Thu, 16 Dec 2021 14:59:51 -0500 (EST) |
branch: elpa/buttercup
commit a91f2820256a4e0c8636cc33a2ef8515a26d3f81
Author: Ola Nilsson <ola.nilsson@gmail.com>
Commit: Ola Nilsson <ola.nilsson@gmail.com>
Handle multiline spec descriptions in buttercup-reporter-batch-color
The default way of printing the description in default color in
spec-started and then using carriage return to re-print it in the
status color does not work for multiline descriptions. Avoid
duplicate output by not printing in spec-started if the description
contains a vertical movement control character.
Fixes #138.
---
buttercup.el | 3 +++
tests/test-buttercup.el | 17 +++++++++++++++++
2 files changed, 20 insertions(+)
diff --git a/buttercup.el b/buttercup.el
index 1bbbf90..8449d87 100644
--- a/buttercup.el
+++ b/buttercup.el
@@ -1651,6 +1651,9 @@ colors.
EVENT and ARG are described in `buttercup-reporter'."
(pcase event
+ (`spec-started
+ (unless (string-match-p "[\n\v\f]" (buttercup-spec-description arg))
+ (buttercup-reporter-batch event arg)))
(`spec-done
(let ((level (length (buttercup-suite-or-spec-parents arg))))
(cond
diff --git a/tests/test-buttercup.el b/tests/test-buttercup.el
index 9726184..025b419 100644
--- a/tests/test-buttercup.el
+++ b/tests/test-buttercup.el
@@ -1158,6 +1158,23 @@ text properties using `ansi-color-apply'."
(expect (buttercup-output) :to-equal-including-properties
(ansi-color-apply
(format "\e[32m spec\e[0m (%s)\n"
+ (buttercup-elapsed-time-string spec)))))
+
+ (it "should print multiline specs cleanly"
+ (setf (buttercup-spec-description spec) "one\ntwo\vthree")
+ (buttercup-reporter-batch 'spec-started spec)
+ (buttercup-reporter-batch 'spec-done spec)
+ (expect (buttercup-output) :to-equal-including-properties
+ (format " one\ntwo\n three (%s)\n"
+ (buttercup-elapsed-time-string spec))))
+
+ (it "should color-print multiline specs cleanly"
+ (setf (buttercup-spec-description spec) "one\ntwo\vthree")
+ (buttercup-reporter-batch-color 'spec-started spec)
+ (buttercup-reporter-batch-color 'spec-done spec)
+ (expect (buttercup-output) :to-equal-including-properties
+ (ansi-color-apply
+ (format "\e[32m one\ntwo\n three\e[0m (%s)\n"
(buttercup-elapsed-time-string spec))))))
(describe "for a failed spec"
- [nongnu] elpa/buttercup 8628d45 208/340: Merge pull request #147 from snogge/suite-local-function, (continued)
- [nongnu] elpa/buttercup 8628d45 208/340: Merge pull request #147 from snogge/suite-local-function, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup a6f2486 211/340: Merge pull request #150 from DarwinAwardWinner/suppress-warning-redirect, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup a019f7a 221/340: Use spy-calls-count as appropriate, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b297b1d 241/340: Revert "Change: (buttercup-define-matcher-for-binary-function) Add newlines", ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 7903e1a 250/340: Revert "Make it possible to abort test run cleanly", ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 521b71b 253/340: Add tests to ensure pending spec state is not overwritten, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 9265f83 258/340: Add test for buttercup-suites-total-specs-pending, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b360e35 264/340: test: Add tests for buttercup--mark-skipped, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 9b94921 276/340: test: Add tests for buttercup-reporter-batch buttercup-done handling, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 2040757 277/340: test: Add reporter test for buttercup-started with pending specs, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup a91f282 283/340: Handle multiline spec descriptions in buttercup-reporter-batch-color,
ELPA Syncer <=
- [nongnu] elpa/buttercup 532d082 284/340: test: Fix tab stops in send-string-to-ansi-buffer for Emacs 24.3, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 8afc407 286/340: Switch from to pcase for spec-done in buttercup-reporter-batch-color, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup d5c3ed5 289/340: Switch to Github Actions, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 41424d5 292/340: Add new public function buttercup-mark-skipped, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 5752a57 295/340: Control errors from buttercup-run with noerror argument, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 2d77e18 300/340: test: Correct descriptions for some suite-done specs, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup d41c6dc 301/340: Extract buttercup-reporter-batch--print-summary, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 74e74e2 302/340: Extract buttercup-reporter-batch--print-failed-spec-report, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 52f0bec 305/340: Make buttercup-colorize treat nil as no color, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup a8f4cff 311/340: test: Correct descriptions for ERT compatibility specs, ELPA Syncer, 2021/12/16