emacs-elpa-diffs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[nongnu] elpa/buttercup b297b1d 241/340: Revert "Change: (buttercup-defi


From: ELPA Syncer
Subject: [nongnu] elpa/buttercup b297b1d 241/340: Revert "Change: (buttercup-define-matcher-for-binary-function) Add newlines"
Date: Thu, 16 Dec 2021 14:59:42 -0500 (EST)

branch: elpa/buttercup
commit b297b1dbfa21c87ffbcfc12d19262765387848de
Author: Ola Nilsson <ola.nilsson@gmail.com>
Commit: Ola Nilsson <ola.nilsson@gmail.com>

    Revert "Change: (buttercup-define-matcher-for-binary-function) Add newlines"
    
    While the change made some tests more readable, it also turned the
    output from this test
    
      (describe "A simple failing test"
        (it "should not look like this"
          (expect 2 :to-equal 1)))
    
    from
    
      A simple failing test should not look like this
    
      Traceback (most recent call last):
        (buttercup-fail "%s" "Expected `2' to be `equal' to `1', but instead it 
wa...
        (signal buttercup-failed "Expected `2' to be `equal' to `1', but 
instead i...
      FAILED: Expected `2' to be `equal' to `1', but instead it was `2' which 
does not match because: (different-atoms (2 "#x2" "?") (1 "#x1" "?")).
    
    into
    
      A simple failing test should not look like this
    
      Traceback (most recent call last):
        (buttercup-fail "%s" "Expected:
          `2'
    
      to be `equal' to:
          `1'
    
      but in...
        (signal buttercup-failed "Expected:
          `2'
    
      to be `equal' to:
          `1'
    
      bu...
      FAILED: Expected:
          `2'
    
      to be `equal' to:
          `1'
    
      but instead it was:
          `2'
    
      which does not match because:
          (different-atoms (2 "#x2" "?") (1 "#x1" "?")).
    
    This reverts commit b2edd3512e61762fecb520b45e50a86991c57358.
---
 buttercup.el | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/buttercup.el b/buttercup.el
index c3bec14..ed58dc3 100644
--- a/buttercup.el
+++ b/buttercup.el
@@ -383,17 +383,7 @@ See also `buttercup-define-matcher'."
             (if explainer
                 ;; %x is the undocumented substitution for the
                 ;; explainer's output
-                "Expected:
-    `%A'
-
-to be `%f' to:
-    `%b'
-
-but instead it was:
-    `%a'
-
-which does not match because:
-    %x."
+                "Expected `%A' to be `%f' to `%b', but instead it was `%a' 
which does not match because: %x."
               "Expected `%A' to be `%f' to `%b', but instead it was `%a'.")))
     (unless expect-mismatch-phrase
       (setq expect-mismatch-phrase



reply via email to

[Prev in Thread] Current Thread [Next in Thread]