[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[nongnu] elpa/buttercup 8628d45 208/340: Merge pull request #147 from sn
From: |
ELPA Syncer |
Subject: |
[nongnu] elpa/buttercup 8628d45 208/340: Merge pull request #147 from snogge/suite-local-function |
Date: |
Thu, 16 Dec 2021 14:59:35 -0500 (EST) |
branch: elpa/buttercup
commit 8628d45b1570a41f857e2e938caa946707f08dd3
Merge: d2b6692 e62ce43
Author: Ola Nilsson <ola.nilsson@gmail.com>
Commit: GitHub <noreply@github.com>
Merge pull request #147 from snogge/suite-local-function
test: Do not leak functions from "The Spy " suite
---
tests/test-buttercup.el | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/tests/test-buttercup.el b/tests/test-buttercup.el
index 06dcce4..e99a964 100644
--- a/tests/test-buttercup.el
+++ b/tests/test-buttercup.el
@@ -613,16 +613,27 @@
;;; Spies
(describe "The Spy "
- (let (test-function)
+ (let (saved-test-function saved-test-command)
;; We use `before-all' here because some tests need to access the
;; same function as previous tests in order to work, so overriding
;; the function before each test would invalidate those tests.
(before-all
+ (setq saved-test-function (and (fboundp 'test-function)
+ (symbol-function 'test-function))
+ saved-test-command (and (fboundp 'test-command)
+ (symbol-function 'test-command)))
(fset 'test-function (lambda (a b)
(+ a b)))
(fset 'test-command (lambda ()
(interactive)
t)))
+ (after-all
+ (if saved-test-function
+ (fset 'test-function saved-test-function)
+ (fmakunbound 'test-function))
+ (if saved-test-command
+ (fset 'test-command saved-test-command)
+ (fmakunbound 'test-command)))
(describe "`spy-on' function"
(it "replaces a symbol's function slot"
- [nongnu] elpa/buttercup 8271c27 254/340: Only update spec state if it is worse or equal, (continued)
- [nongnu] elpa/buttercup 8271c27 254/340: Only update spec state if it is worse or equal, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 966798f 255/340: Correct all docstrings to pass checkdoc, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b520dcf 257/340: Print test run duration in an apropriate unit, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 1fd0d8b 260/340: Set state pending for skipped specs for correct initial count, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b298517 262/340: test: Mark some local function arguments as unused, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 8e29f4c 259/340: Extract buttercup--mark-skipped from buttercup-run-discover, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 669ca99 267/340: test: Split make rule test into test-buttercup and test-docs, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 6655f77 269/340: Update test run duration output in buttercup-reporter-batch, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 0e6c09e 271/340: Correct the assume docstring, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 6848057 167/340: Bump version: 1.9 → 1.10, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 8628d45 208/340: Merge pull request #147 from snogge/suite-local-function,
ELPA Syncer <=
- [nongnu] elpa/buttercup a6f2486 211/340: Merge pull request #150 from DarwinAwardWinner/suppress-warning-redirect, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup a019f7a 221/340: Use spy-calls-count as appropriate, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b297b1d 241/340: Revert "Change: (buttercup-define-matcher-for-binary-function) Add newlines", ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 7903e1a 250/340: Revert "Make it possible to abort test run cleanly", ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 521b71b 253/340: Add tests to ensure pending spec state is not overwritten, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 9265f83 258/340: Add test for buttercup-suites-total-specs-pending, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup b360e35 264/340: test: Add tests for buttercup--mark-skipped, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 9b94921 276/340: test: Add tests for buttercup-reporter-batch buttercup-done handling, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup 2040757 277/340: test: Add reporter test for buttercup-started with pending specs, ELPA Syncer, 2021/12/16
- [nongnu] elpa/buttercup a91f282 283/340: Handle multiline spec descriptions in buttercup-reporter-batch-color, ELPA Syncer, 2021/12/16