Re: NonGNU ELPA: add Logview

[Stefan Kangas]

"Bozhidar Batsov" <bozhidar@batsov.dev> writes:

> Any chance of someone looking into this? It's a bit disappointing that a year 
> and a half later we're still where we started and CIDER users are forced to 
> rely on additional repositories to be able to install logview. :(

Stefan M, could you please help look into this?

AFAIU, there is a patch in this mail thread that just needs to be pushed
it to NonGNU ELPA:
https://lists.gnu.org/r/emacs-devel/2023-07/msg00194.html

I'm not aware of any specific blockers.

> On Thu, Jul 13, 2023, at 4:34 PM, Bozhidar Batsov wrote:
>> Just bumping this conversation, as we're still looking for someone to help 
>> us apply the patch.
>>
>> On Fri, Jul 7, 2023, at 8:21 AM, Bozhidar Batsov wrote:
>>> Yeah, CIDER recently introduced some functionality that uses Logview 
>>> internally (see https://docs.cider.mx/cider/debugging/logging.html), that's 
>>> why for us it's important for the package to be available on NonGNU ELPA. I 
>>> think that Logview is a great and very useful package on its own, btw, so 
>>> even without CIDER's immediate need I'd still advocate for its inclusion 
>>> there.
>>>
>>> Can't speak about Logview's deps (as I'm not familiar with them), but I 
>>> know Paul is a great package maintainer, so I'm pretty sure that if he had 
>>> to create some additional library there was a real need for it.
>>>
>>> On Thu, Jul 6, 2023, at 10:47 PM, Paul Pogonyshev wrote:
>>>> > Without understanding the issue properly, why is there a need for an 
>>>> > external data-time parsing package, if Emacs already comes with 
>>>> > functions for parsing timestamps?
>>>>
>>>> For speed. Logview is aimed at very large logs (megabytes) and also for 
>>>> lazily filtering them on-the-fly, adding/removing filters and so on. 
>>>> Built-in functions were not fast enough, so I had to create datetime. Also 
>>>> for matching: there is no standard timestamp format, the library helps me 
>>>> at building regexs needed to match timestamps in given format and also 
>>>> trying to guess which of many possible formats to use for a particular 
>>>> file.
>>>>
>>>> I didn't create the library just for fun, I saw a need for it.
>>>>
>>>> > It appears to use use this extmap package, which parses binary data?
>>>>
>>>> Yes.
>>>>
>>>> > How is this all related to CIDER?
>>>>
>>>> "This all" is not related to CIDER, because this is Logview's 
>>>> implementation details. CIDER recently added some log-related 
>>>> functionality and they'd like to use Logview as the base for their mode, 
>>>> as far as I understand. They don't need datetime or extmap, but according 
>>>> to NonGNU ELPA policy, Logview cannot be added without its dependencies.
>>>>
>>>> > If possible, please add ".elpaignore" files to the repositories 
>>>> > themselves, so that we can void tracking the files in elpa-packages 
>>>> > itself.
>>>>
>>>> OK, I will do that if the packages get added to the archive. Don't want to 
>>>> create files while I'm not sure they would be used for anything.
>>>>
>>>> Paul
>>>>
>>>> On Thu, 6 Jul 2023 at 19:59, Philip Kaludercic <philipk@posteo.net> wrote:
>>>>>
>>>>> "Bozhidar Batsov" <bozhidar@batsov.dev> writes:
>>>>>
>>>>> > Thanks for putting the patch together so quickly!
>>>>> >
>>>>> > Phillip, can you help us to get it applied?
>>>>>
>>>>> Applying the patch is not the issue, I am just personally hesitant to
>>>>> add a bunch of dependencies/packages I have never heard about before,
>>>>> more so because I don't use CIDER, /especially/ when I lack the time to
>>>>> properly review them (the argument that a package is "mature on MELPA"
>>>>> is rather weak from my experience, especially given the number of low
>>>>> quality packages on the archive).
>>>>>
>>>>> Without understanding the issue properly, why is there a need for an
>>>>> external data-time parsing package, if Emacs already comes with
>>>>> functions for parsing timestamps?  It appears to use use this extmap
>>>>> package, which parses binary data?  How is this all related to CIDER?
>>>>>
>>>>> But perhaps I am in a minority here, and we should just apply the patch.
>>>>>
>>>>> > On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
>>>>> >> Hi,
>>>>> >>
>>>>> >> Bozhidar Batsov, author and maintainer of CIDER, requested for
>>>>> >> package Logview to be made available on NonGNU ELPA:
>>>>> >> https://github.com/clojure-emacs/cider/issues/3365
>>>>> >>
>>>>> >> Since Logview has two dependencies itself, which are not available
>>>>> >> on NonGNU ELPA, and since Bozhidar assured me that it is fine to
>>>>> >> submit multiple packages in one go, the attached patch adds all
>>>>> >> three (Logview, datetime, extmap) at once. Local checks suggest that
>>>>> >> the packages can be built fine.
>>>>>
>>>>> I am a bit confused, why should adding multiple related packages in a
>>>>> single patch be an issue?
>>>>>
>>>>> >> All the packages have been available from MELPA for years and are
>>>>> >> mature projects. They are under active maintenance: even if I don't
>>>>> >> often add new features, I respond to reported issues on GitHub and
>>>>> >> write fixes when needed.
>>>>> >>
>>>>> >> I added directory `githooks' to the lists of exclusions even if it
>>>>> >> doesn't yet exist in the dependencies: I will add it there sooner or
>>>>> >> later anyway. In Logview itself this directory already exists.
>>>>>
>>>>> If possible, please add ".elpaignore" files to the repositories
>>>>> themselves, so that we can void tracking the files in elpa-packages
>>>>> itself.
>>>>>
>>>>> >> Please CC me on any replies, I'm not subscribed to the list.
>>>>>
>>>>> That is a given, don't worry about it.
>>>>>
>>>>> >> Paul
>>>>> >>
>>>>> >> *Attachments:*
>>>>> >>  • 0001-Add-Logview-with-dependencies.patch
>>>
>>