The logview package is relatively popular and well written IMO. Yeah, it's an optional CIDER dependency, but it enhances a lot CIDER's log viewer, that's why I'm keen on having it here. If we want ELPA to become a viable alternative to 3rd party repos we can't be too picky when it comes to the standards for including something. The author is not using ELPA, so his incentive to do extra work for the inclusion is little, if any.
> Any chance of someone looking into this? It's a bit disappointing that
> a year and a half later we're still where we started and CIDER users
> are forced to rely on additional repositories to be able to install
> logview. :(
Just to clarify in case anyone else was surprised to read this thinking
that the package was broken due to an unresolvable dependency: Cider
(AFAIU it is a package like SLIME for Common Lisp) has an /optional/
dependency on a third-party package called "logview". This means that
Cider can still be installed without having enable additional archives,
but if it is available, the integration with logview is enabled or
disabled via a user option `cider-log-use-logview'.
Logview (4k+ lines) still remains a big blob to me, especially as it has
two dependencies: "datetime" (2k+ lines) and "extmap" (600+ lines). If
Stefan feels comfortable with adding them, then that is fine, but
finding the time to properly review almost 7000 lines of code take a lot
of energy and time that I don't feel like I can bring up :/ It doesn't
help that the maintainer doesn't seem to be interested in feedback...
You saw as much as I did, it was basically ignored. Since I hate
Emacs-devel anyway, I'm not going to ping it or argue with them when
they say that ten things have to be reimplemented or "why had you do
it like this and not like that", sorry.
> On Thu, Jul 13, 2023, at 4:34 PM, Bozhidar Batsov wrote:
>> Just bumping this conversation, as we're still looking for someone to help us apply the patch.
>>
>> On Fri, Jul 7, 2023, at 8:21 AM, Bozhidar Batsov wrote:
>>> Yeah, CIDER recently introduced some functionality that uses
>>> Logview internally (see
>>> us it's important for the package to be available on NonGNU ELPA. I
>>> think that Logview is a great and very useful package on its own,
>>> btw, so even without CIDER's immediate need I'd still advocate for
>>> its inclusion there.
>>>
>>> Can't speak about Logview's deps (as I'm not familiar with them),
>>> but I know Paul is a great package maintainer, so I'm pretty sure
>>> that if he had to create some additional library there was a real
>>> need for it.
>>>
>>> On Thu, Jul 6, 2023, at 10:47 PM, Paul Pogonyshev wrote:
>>>> > Without understanding the issue properly, why is there a need
>>>> > for an external data-time parsing package, if Emacs already
>>>> > comes with functions for parsing timestamps?
>>>>
>>>> For speed. Logview is aimed at very large logs (megabytes) and
>>>> also for lazily filtering them on-the-fly, adding/removing filters
>>>> and so on. Built-in functions were not fast enough, so I had to
>>>> create datetime. Also for matching: there is no standard timestamp
>>>> format, the library helps me at building regexs needed to match
>>>> timestamps in given format and also trying to guess which of many
>>>> possible formats to use for a particular file.
>>>>
>>>> I didn't create the library just for fun, I saw a need for it.
>>>>
>>>> > It appears to use use this extmap package, which parses binary data?
>>>>
>>>> Yes.
>>>>
>>>> > How is this all related to CIDER?
>>>>
>>>> "This all" is not related to CIDER, because this is Logview's
>>>> implementation details. CIDER recently added some log-related
>>>> functionality and they'd like to use Logview as the base for their
>>>> mode, as far as I understand. They don't need datetime or extmap,
>>>> but according to NonGNU ELPA policy, Logview cannot be added
>>>> without its dependencies.
>>>>
>>>> > If possible, please add ".elpaignore" files to the repositories themselves, so that we can void tracking the files in elpa-packages itself.
>>>>
>>>> OK, I will do that if the packages get added to the archive. Don't want to create files while I'm not sure they would be used for anything.
>>>>
>>>> Paul
>>>>
>>>>>
>>>>>
>>>>> > Thanks for putting the patch together so quickly!
>>>>> >
>>>>> > Phillip, can you help us to get it applied?
>>>>>
>>>>> Applying the patch is not the issue, I am just personally hesitant to
>>>>> add a bunch of dependencies/packages I have never heard about before,
>>>>> more so because I don't use CIDER, /especially/ when I lack the time to
>>>>> properly review them (the argument that a package is "mature on MELPA"
>>>>> is rather weak from my experience, especially given the number of low
>>>>> quality packages on the archive).
>>>>>
>>>>> Without understanding the issue properly, why is there a need for an
>>>>> external data-time parsing package, if Emacs already comes with
>>>>> functions for parsing timestamps? It appears to use use this extmap
>>>>> package, which parses binary data? How is this all related to CIDER?
>>>>>
>>>>> But perhaps I am in a minority here, and we should just apply the patch.
>>>>>
>>>>> > On Thu, Jul 6, 2023, at 7:14 PM, Paul Pogonyshev wrote:
>>>>> >> Hi,
>>>>> >>
>>>>> >> Bozhidar Batsov, author and maintainer of CIDER, requested for
>>>>> >> package Logview to be made available on NonGNU ELPA:
>>>>> >>
>>>>> >> Since Logview has two dependencies itself, which are not available
>>>>> >> on NonGNU ELPA, and since Bozhidar assured me that it is fine to
>>>>> >> submit multiple packages in one go, the attached patch adds all
>>>>> >> three (Logview, datetime, extmap) at once. Local checks suggest that
>>>>> >> the packages can be built fine.
>>>>>
>>>>> I am a bit confused, why should adding multiple related packages in a
>>>>> single patch be an issue?
>>>>>
>>>>> >> All the packages have been available from MELPA for years and are
>>>>> >> mature projects. They are under active maintenance: even if I don't
>>>>> >> often add new features, I respond to reported issues on GitHub and
>>>>> >> write fixes when needed.
>>>>> >>
>>>>> >> I added directory `githooks' to the lists of exclusions even if it
>>>>> >> doesn't yet exist in the dependencies: I will add it there sooner or
>>>>> >> later anyway. In Logview itself this directory already exists.
>>>>>
>>>>> If possible, please add ".elpaignore" files to the repositories
>>>>> themselves, so that we can void tracking the files in elpa-packages
>>>>> itself.
>>>>>
>>>>> >> Please CC me on any replies, I'm not subscribed to the list.
>>>>>
>>>>> That is a given, don't worry about it.
>>>>>
>>>>> >> Paul
>>>>> >>
>>>>> >> *Attachments:*
>>>>> >> • 0001-Add-Logview-with-dependencies.patch
>>>
>>