Re: ERT / find-function type integration typos

[Stephen Gildea]

Eshel Yaron <me@eshelyaron.com> wrote:

>   > -(defcustom find-ert-deftest-regexp
>   > -  "(ert-deftest +'%s"
>   > -  "The regexp used to search for an `ert-deftest' definition.
>   > -Note it must contain a `%s' at the place where `format'
>   > -should insert the feature name."
>   > -  :type 'regexp
>   > -  :group 'xref
>   > -  :version "29.1")
>   
>   We may want to keep this option, and maybe even use it instead of
>   ert--find-test-regexp, just in case somebody decided to customize it.

Nobody is customizing this, at least not to any effect.
Because it is attached to find-function-regexp-alist with the
wrong key (ert-deftest), see 20 lines later, it has no effect.
Nobody is going to miss it.

Also, our new property find-function-type-alist replaces and
is more powerful than customizing "find-foo-regexp" variables.

>   Otherwise I think it looks pretty good, thanks for looking into this!

Thanks for the review.

 < Stephen