Re: Functions transpose/rotate/flip windows

[Eshel Yaron]

Pranshu <pranshu@bauherren.ovh> writes:

> On 11 January 2025 7:08:19 pm GMT+05:30, Eshel Yaron <me@eshelyaron.com> 
> wrote:
>>Hi all,
>>
>>martin rudalics <rudalics@gmx.at> writes:
>>
>>>> Ok, I fixed them now.  A new diff is attached.
>>>
>>> I pushed window-x.el to master now without any further testing or
>>> looking into it.  I plan to fix a few things in it but maybe Eli wants
>>> to make some major corrections first.
>>
>>Thanks for working on these additions, the new commands seem neat.
>>
>>The only functional issue I ran into is that rotate-windows and
>>rotate-windows-back seem to leave the wrong window selected (the
>>selection does not follow the rotation).
>>
>>Other than that, here are some clean up suggestions from a quick pass:
>>
[...]
>
> Thanks for the code review I will look at it soon.

Great, note that some of the suggested changes are based on my stylistic
preference, so feel free to ignore parts that you prefer unchanged.

What's important IMO is to add the (provides 'window-x) form and the
autoload cookies.

> Selecting the rotated window is intended behaviour, as if means you
> can use the function as a practical alternative or 'other-window'.

Got it, thanks for the clarification.


Best,

Eshel