Re: with-editor seems like a bug fix

[Manuel Giraud]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Michael Albinus <michael.albinus@gmx.de>
>> Cc: manuel@ledu-giraud.fr,  rms@gnu.org,  emacs-devel@gnu.org,
>>   jonas@bernoul.li
>> Date: Sat, 29 Jun 2024 14:47:07 +0200
>> 
>> >> TL;DR: I don't believe with-editor is just a bug fix. There are reasons
>> >>        for the implementation as-it-is. It might profit from using
>> >>        emacsclient also for the remote case (when possible), but nobody
>> >>        has taken the stab.
>> >
>> > I don't see how we can discuss a package which solves problems we
>> > don't understand.
>> 
>> Oh, we understand. When there is no emacsclient on the remote host, we
>> cannot use it. with-editor solves this problems.
>
> I meant in the local case.

FWIW, I have never yet encountered a case, where having the emacs server
started and EDITOR set to "emacsclient" failed in the local case.

That said, skimming through the with-editor's code, it seems to try real
hard to find a correct emacsclient (even "remacsclient" for remacs!)  It
even seems to start the emacs server if it is not already the case.  So
I agree that it could be declared "broken" installations.
-- 
Manuel Giraud