emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 101f3cf5b9: Add support for user edits to VC command argument


From: Robert Pluim
Subject: Re: master 101f3cf5b9: Add support for user edits to VC command arguments
Date: Fri, 23 Sep 2022 10:03:37 +0200

>>>>> On Thu, 22 Sep 2022 09:06:48 -0700, Sean Whitton 
>>>>> <spwhitton@spwhitton.name> said:

    Sean> Hello,
    Sean> On Thu 22 Sep 2022 at 11:25AM +02, Robert Pluim wrote:

    >>>>>>> On Wed, 21 Sep 2022 15:33:02 -0400 (EDT), Sean Whitton 
<spwhitton@spwhitton.name> said:
    >> 
    >> 
    Sean> +(defvar vc-want-edit-command-p nil
    Sean> +  "If non-nil, let user edit the VC shell command before running 
it.")
    Sean> +
    Sean> ;; Common command execution logic
    >> 
    >> Is the intent that someone would setq this to t? If so it should be a
    >> defcustom. If thatʼs not the intent, but itʼs just being used to track
    >> the prefix args to the various changed commands, then I think it
    >> shouldnʼt appear in the docstring.

    Sean> It's the latter, it's not meant to be setq.

    Sean> What exactly do you think shouldn't appear in the docstring?

Any reference to `vc-want-edit-command-p', if it truly is just an
internal implementation detail.

Robert
-- 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]