Re: master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X

[Eli Zaretskii]

> Date: Tue, 11 Jan 2022 13:18:20 +0000 (UTC)
> From: Po Lu <luangruo@yahoo.com>
> Cc: emacs-devel@gnu.org
> 
> [Sorry for the webmail, Yahoo SMTP is wedged; I hope Reply All worked
> and this reaches the list]

It did work.

> > I have a problem with this correction, because I don't understand the
> > need for it. s->width is the width of the glyph string, which is
> > computed from the glyphs that comprise the glyph string. Those glyphs
> > were laid out by display_line, which should never add a glyph to a
> > glyph row if that glyph doesn't fit on the screen. So how come
> > s->width in your case was too large? Or maybe it's s->x that was
> > wrong (does the underline start exactly under the first glyph)?
> 
> > So I suspect that your fix hides a much more serious problem
> > elsewhere. Please investigate the problem you saw before the change.
> 
> Thanks, will do. Should I revert this fix?

I don't see a reason to revert immediately, as the change doesn't do
any particular harm, being on master.  It's up to you.