emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 77c3d41adc: Prevent text decorations from overwriting surroun


From: Po Lu
Subject: Re: master 77c3d41adc: Prevent text decorations from overwriting surrounding areas on X
Date: Tue, 11 Jan 2022 13:18:20 +0000 (UTC)

[Sorry for the webmail, Yahoo SMTP is wedged; I hope Reply All worked
and this reaches the list]

> I have a problem with this correction, because I don't understand the
> need for it. s->width is the width of the glyph string, which is
> computed from the glyphs that comprise the glyph string. Those glyphs
> were laid out by display_line, which should never add a glyph to a
> glyph row if that glyph doesn't fit on the screen. So how come
> s->width in your case was too large? Or maybe it's s->x that was
> wrong (does the underline start exactly under the first glyph)?

> So I suspect that your fix hides a much more serious problem
> elsewhere. Please investigate the problem you saw before the change.

Thanks, will do. Should I revert this fix?

reply via email to

[Prev in Thread] Current Thread [Next in Thread]