Re: [PATCH] Gnus; Restore multi encoding support for NNTP

[Lars Ingebrigtsen]

LdBeth <andpuke@foxmail.com> writes:

> +  (let ((pos (text-property-not-all 0 (length string) 'charset nil string)))
> +    (if pos (encode-coding-string string (get-text-property pos 'charset 
> string))
> +      string)))

Like I said before, I'm not really very enthusiastic about stashing this
data in the text properties -- it's quite likely that there are packages
or functions of there that'll do various transforms on the group names,
and the text properties may be lost.  If this data has to be stored
non-ephemerally, then storing it in the group parameter list, for
instance, would be less brittle.

> @@ -472,7 +472,7 @@ gnus-request-compact-group
>        (result
>         (funcall (gnus-get-function gnus-command-method
>                                     'request-compact-group)
> -                (gnus-group-real-name group)
> +                (gnus-group-real-name (gnus-group-encoded-name group))
>                  (nth 1 gnus-command-method) t)))
>      result))

(etc.)  And I'm not sure about giving the backends the encoded names --
that's a major change in behaviour, and has to end up causing problems
somewhere (for instance, in nnimap which is encoded to utf-7, and would
be double-encoded if there's a `charset' text property on the group
name).

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no