emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: New package: resist!


From: Qiantan Hong
Subject: Re: New package: resist!
Date: Fri, 10 Dec 2021 19:15:14 +0000

> I just looked at the code and I think it should be cleaner w.r.t its use
> of namespace: the file is `resist!.el` and it defines macros and
> functions using the `kv-` prefix as well as the `persistent-` prefix; we
> should unify those 3 names.
> 
> [ Also the advice functions should have a name that starts with the
>  package's namespace prefix.  ]
I’m thinking the “package” as an extension to Elisp language itself,
so I didn’t have package prefix in mind. Thus the name like `compact-kv-store`.

Maybe the file should be named `persistence.el`?

>> There’s some remaining technical question:
>> - What’s the right group to put the customizations?
>> - currently I ask user to invoke kv-compact-demon-start
>>  and persistent-variable-demon-start explicitly to
>>  start/restart the services.
>>  Are there better way?
>>  Not sure if those makes sense as minor modes.
> 
> Why not start them lazily when the data is changed (e.g. within
> `kv--ensure-transaction`)?
Sure, that will work, thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]