Now branch isearch-vertical

[Ergus]

Hi Gregory:

I see that you added a new feature branch to finally implement
icomplete-vertical. Let's hope this time it will be added.

If you permit me 3 suggestions:

1) Could you add some customs for the separators? This may simplify the
"unless" calls you needed to add twice. But also will permit the user to
configure them.

IMO the best alternative is a sort of format; but at least setting the 
{} [] and () somehow will be very handy... maybe with a const pair.

2) I am wondering about the icomplete-code that determines the number of
candidates. IIRC the candidates are determined by the windows
width... so maybe that needs some check? Because with narrow
windows or long candidates the list may be needlessly truncated in
vertical?

3) When you corrected my branch that time ago I remember that your
recommendation was to respect the user option icomplete-separator. To
detect if it had a "\n". Now that most of the display issues are solved
and the setup is simpler.

Isn't it possible to do that with a simple (if) in
icomplete-minibuffer-setup instead of adding a hook?; setting some
variables and then avoid all the `unless` and `if` in the (if prospects)
part? So we don't need the extra mode and the setup for the user will be
simpler.

Best,
Ergus

On Sat, Apr 10, 2021 at 10:57:33AM +0000, Gregory Heytings wrote:
> > > I attach the updated patch, in which I included your other suggestions.
> >
> > Thanks, this LGTM, but I wonder whether we should use \\[foo] 
> > instead of a literal `foo' in the doc strings, since users are 
> > likely to use the key sequences, not the command names.
>
> Thanks, see attached.