emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Making TTY menus more visual


From: Eli Zaretskii
Subject: Re: Making TTY menus more visual
Date: Tue, 13 Oct 2020 17:33:24 +0300

> Date: Mon, 12 Oct 2020 14:30:38 -0700
> From: Jared Finder <jared@finder.org>
> Cc: emacs-devel@gnu.org
> 
> Thanks, I investigated further and I have an improved patch attached.  
> In addition to keeping the same interactive spec, it also is logically 
> independent of my changes to enable xterm-mouse based menu interaction.  
> I also attached repro.el, which I used to help understand the behavior 
> of xterm-mouse.

Thanks, I think this is a much better variant.

> The manual is not clear of the format of a posn for clicks outside a 
> window, such as on the menu bar or tab bar. From the behavior I see, 
> posn-window will return nil and posn-x-y will return (x . y) in frame 
> coordinates. I rely on that in this patch. If this is accurate, I can 
> update the manual.

Are you sure posn-window cannot return a frame?  For example, on a
TTY, I get this:

  (posn-at-x-y 0 0 (selected-frame))
   => (#<frame F1 069b0190> nil (0 . 0) 0)

And (0,0) are coordinates in the frame's menu bar.

Does it make sense to install this patch on its own?  If so, we can
install it without waiting for the legal paperwork, the changes are
small enough.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]