emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 3139551: Don’t attempt to modify constant strings


From: Paul Eggert
Subject: Re: master 3139551: Don’t attempt to modify constant strings
Date: Sun, 17 May 2020 10:10:10 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 5/17/20 4:24 AM, Dmitry Gutov wrote:
>> -;; (password-cache-add "test" "foo")
>> +;; (password-cache-add "test" (copy-sequence "foo"))
>>   ;;  => nil
> 
> This seems like a false positive.

It's just a comment. Since there are so many ways that a password cache can be
cleared and clearing means the strings holding passwords need to be mutable, I
thought it better for the comment to reflect good practice.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]