emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 3139551: Don’t attempt to modify constant strings


From: Dmitry Gutov
Subject: Re: master 3139551: Don’t attempt to modify constant strings
Date: Sun, 17 May 2020 14:22:38 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0

On 17.05.2020 08:25, Paul Eggert wrote:
  ;; WORKAROUND: This is nominally a constant, but the text properties
  ;; are not preserved thru dump if use defconst.  See bug#21237.
  (defvar elisp--xref-format
-  (let ((str "(%s %s)"))
-    (put-text-property 1 3 'face 'font-lock-keyword-face str)
-    (put-text-property 4 6 'face 'font-lock-function-name-face str)
-    str))
+  #("(%s %s)"
+    1 3 (face font-lock-keyword-face)
+    4 6 (face font-lock-function-name-face)))

Seems like the comment is calling for some further changes.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]