emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Towards a cleaner build


From: Lars Ingebrigtsen
Subject: Re: Towards a cleaner build
Date: Fri, 17 May 2019 04:50:54 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

epa declares a bunch of functions for interactive use only, and then
uses the functions itself, which seems like an error, like this:

;;;###autoload
(defun epa-mail-verify ()
  "Verify OpenPGP cleartext signed messages in the current buffer.
The buffer is expected to contain a mail message."
  (declare (interactive-only t))
  (interactive)
  (epa-verify-cleartext-in-region (point-min) (point-max)))

`epa-verify-cleartext-in-region' is defined as interactive-only.

I suggest that the -in-region function have the interactive spec
removed.  Any objections?



In epa-verify-cleartext-in-region:
epa.el:998:46:Warning: ‘epa-verify-region’ is for interactive use only.
  ELC      epa-file.elc

In epa-mail-decrypt:
epa-mail.el:72:4:Warning: ‘epa-decrypt-armor-in-region’ is for interactive use
    only.

In epa-mail-verify:
epa-mail.el:80:4:Warning: ‘epa-verify-cleartext-in-region’ is for interactive
    use only.

In epa-mail-sign:
epa-mail.el:106:10:Warning: ‘epa-sign-region’ is for interactive use only.

In epa-mail-encrypt:
epa-mail.el:225:12:Warning: ‘epa-encrypt-region’ is for interactive use only.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no




reply via email to

[Prev in Thread] Current Thread [Next in Thread]