Re: Fill column indicator functionality

[Ergus]

Hi all:

I have been playing with the display engine in order to try to implement
this functionality (at least a proof of concept). But after reading the
comments and the ~33E3 lines in xdisp.c there are more questions now
than answers.

The simplest approach I see is to add a '|' (or similar) in the desired
column in the "at_end_of_line:" label. But maybe there is a better
approach?

My approach is somehow based on the display_line_numbers, but taking
into account that in this case the characters are always the same, maybe
there is a way to set them in the background and it will be simpler?

Is it there any documentation about this? specially the relations
between the data structures? because the it and the glyphs are very
confusing.

Any help please?



On Mon, Feb 11, 2019 at 07:13:25PM +0200, Eli Zaretskii wrote:
> > Date: Mon, 11 Feb 2019 17:56:36 +0100
> > From: Jimmy Aguilar Mena <address@hidden>
> > Cc: Ergus <address@hidden>, address@hidden, address@hidden,
> >         address@hidden
> >
> > >> I have been checking the display engine and the commits to add the
> > >> display-line-number functionality. With this, it really looks much
> > >> simpler to implement the version of the vertical line (character at
> > >> column X).
> > >
> > >I'm not sure I understand: much simpler than what alternative?
> > >
> > The color change one.
>
> I don't think it's easier, I think both could be implemented with
> similar efforts, and in the same place in the code.  (Caveat: I only
> thought a little bit about the implementation, so I might be missing
> some important details.)
>
> > BTW, is it there any legal paperwork before contributing?
>
> If you don't have a copyright assignment for contributing to Emacs,
> you should start the legal paperwork rolling, so that it's in place by
> the time you will have code to contribute.
>
> Thanks.