Re: Inclusion of XDG Base Directory library

[Eli Zaretskii]

> Cc: address@hidden
> From: Francisco Miguel Colaço <address@hidden>
> Date: Fri, 11 May 2018 21:22:37 +0100
> 
>   Thanks for the heads up.  The windows-shell-folder and
> windows-read-registry-value, which I thought were part of Windows Emacs,
> were added to user-directories-windows-nt.el.

Thanks.

>   I have not tested Windows NT code because I do not currently own any
> Windows computer and the virtual machines on which I run it do not have
> Emacs.  So, I am dependent on the goodwill and patches from the many
> that use Emacs on Microsoft platforms.

I understand.  Therefore, I raised an issue with the package, listing
there the problems I see in the code, and I hope the person(s) who
contributed this code will take notice and fix the problems I
mentioned there.

(Btw, I suggest to keep track of all your contributors, otherwise we
will have difficulties admitting the code into ELPA later.)

>   According to http://environmentvariables.org/LocalAppData, the
> variable was introduced in Windows Vista and defaults to
> C:\Users\{username}\AppData\Local.

That's exactly my point: Emacs on Windows still tries to support
versions of Windows that predate Vista.  The code should not fail for
them, but should provide fallbacks for those directories that were
introduced in more recent versions.

In addition, I think it's gross to use 'reg' and 'echo' as external
commands to produce the Registry values; in particular, this will fail
if the values include non-ASCII characters not from the system locale.
We should have primitives for that.  Volunteers are welcome to add
such capabilities to Emacs.

>   About Linux, the canonical way to get an XDG user folder is by the use
> of the command xdg-user-dir.  The alternative is to parse
> ~/.config/user-dirs.dirs, something that is already done by
> xdg-user-dir.  Here are two lines of mine (European Portuguese):
> 
>   XDG_DESKTOP_DIR="$HOME/Área de Trabalho"
>   XDG_DOWNLOAD_DIR="$HOME/Transferências"
> 
>   Although it does not pose a gruesome task to parse it (blessed be
> regexps), as far as I can understand the XDG Base Directory Standard the
> recommended way to find directories is not to parse the file, but to use
> the command.  Every distribution since near 2010 includes
> xdg-user-dirs.  I can write parsing code, but it seems inadequate,
> considering there is a blessed way to perform the search.

IMO, the advantage of parsing files in Emacs is that we can be more
sure we deal properly with non-ASCII file names.  When you invoke a
command to do the job for you, you rely on guesswork for decoding what
the program outputs, which could be tricky, especially when you do
that remotely from another system, with a different locale.  By
contrast, I expect the file to be encoded in UTF-8 always, is that
right?