emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Why does make run git?


From: Eli Zaretskii
Subject: Re: Why does make run git?
Date: Wed, 02 Aug 2017 22:10:52 +0300

> Cc: address@hidden, address@hidden, address@hidden
> From: Paul Eggert <address@hidden>
> Date: Wed, 2 Aug 2017 11:42:43 -0700
> 
> On 08/02/2017 11:31 AM, Eli Zaretskii wrote:
> >> To help improve the situation I propose the attached patch, which
> >> reverts the default ./autogen.sh behavior to be './autogen.sh all', the
> >> way it used to be (briefly). Developers who want autogen.sh to leave
> >> their Git settings alone can continue to use './autogen.sh autoconf'.
> > AFAIU, doing that will silently force the installation of the
> > Git-related stuff when I run just "make", and Make decides it needs to
> > invoke autogen.sh, because the fact that I originally used the
> > non-default argument isn't recorded anywhere, and thus cannot be
> > replayed.  Right?
> 
> No, if you run Make from a freshly-checked-out directory, Make calls 
> "./autogen.sh all", which sets up Git. The proposed patch doesn't affect 
> this.
> 
> And if you run "./autogen.sh autoconf" and then run Make, Make won't set 
> up Git. The proposed patch doesn't affect this either.

Maybe I'm confused, but top-level Makefile.in has this:

  $(srcdir)/configure: $(srcdir)/configure.ac $(srcdir)/m4/*.m4
          cd $(srcdir) && ./autogen.sh

This seems to say that if configure.ac or one of the *.m4 files become
newer than configure, either because I edit them or because I just
pulled from upstream, then Make will run "./autogen.sh", which under
the default you propose will configure Git.  If that's not true, then
what am I missing?



reply via email to

[Prev in Thread] Current Thread [Next in Thread]