Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).

[Stephen Berman]

On Wed, 15 Jun 2016 23:04:27 -0400 Noam Postavsky <address@hidden> wrote:

> On Wed, Jun 15, 2016 at 2:10 PM, Stephen Berman <address@hidden> wrote:
>>
>> Thanks, done as commit 5d4d8a3.
>
> I think it does nothing but bind minibuffer-local-completion-map to
> nil, since define-key doesn't return the map. You should have
>
>   (let ((minibuffer-local-completion-map
>          (let ((map (make-sparse-keymap)))
>            (set-keymap-parent map minibuffer-local-completion-map)
>            (define-key map " " nil)
>            map))) ; <---------- use the map

Thanks for catching that.  Fix pushed to emacs-25 as commit 2317c61.  (I
had tested my previous change before committing it, but only that SPC
worked as intended (because it is bound to the global map), and
neglected the other minibuffer bindings.)

Steve Berman