emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer comp


From: Stefan Monnier
Subject: Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).
Date: Tue, 14 Jun 2016 22:12:01 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux)

> -  (let ((map minibuffer-local-completion-map))
> -    (define-key map " " nil)
> +  (let ((minibuffer-local-completion-map
> +         (copy-keymap minibuffer-local-completion-map)))
> +    (define-key minibuffer-local-completion-map " " 'self-insert-command)

Why bind it to `self-insert-command` rather than to nil?


        Stefan


PS: You can avoid copying with something like

  (let ((minibuffer-local-completion-map
         (let ((map (make-sparse-keymap)))
           (set-parent-keymap map minibuffer-local-completion-map)
           (define-key minibuffer-local-completion-map
                       " " 'self-insert-command))))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]