[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer comp
From: |
Noam Postavsky |
Subject: |
Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695). |
Date: |
Wed, 15 Jun 2016 23:04:27 -0400 |
On Wed, Jun 15, 2016 at 2:10 PM, Stephen Berman <address@hidden> wrote:
>
> Thanks, done as commit 5d4d8a3.
I think it does nothing but bind minibuffer-local-completion-map to
nil, since define-key doesn't return the map. You should have
(let ((minibuffer-local-completion-map
(let ((map (make-sparse-keymap)))
(set-keymap-parent map minibuffer-local-completion-map)
(define-key map " " nil)
map))) ; <---------- use the map
...
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stefan Monnier, 2016/06/14
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stephen Berman, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stefan Monnier, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stephen Berman, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Eli Zaretskii, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., John Wiegley, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stephen Berman, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).,
Noam Postavsky <=
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stephen Berman, 2016/06/16
- Generalizing make-composed-keymap (was: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695).), Stefan Monnier, 2016/06/15
- Re: Generalizing make-composed-keymap, Clément Pit--Claudel, 2016/06/15
- Re: Generalizing make-composed-keymap, Stefan Monnier, 2016/06/15
- Re: [Emacs-diffs] emacs-25 d7084f2: Fix todo-mode use of minibuffer completion keymap (bug#23695)., Stefan Monnier, 2016/06/15