Re: C-g crash redux

[David Kastrup]

address@hidden (Kim F. Storm) writes:

> Nick Roberts <address@hidden> writes:
>
>>  > The previous code suggestion I gave was not well thought out.  The
>>  > correct way to implement this is as follows.  I've checked that with
>>  > this change, the addition of wait_reading_process_output_unwind does
>>  > not cause a crash when C-g is done during sit-for.
>>  > 
>>  > Do you think this is the right approach?
>
> Clever!  Yes.  
>
>
>>  >... 
>>
>> It looks good to my inexperienced eye, but Emacs seems to go for a long time
>> before hitting Fsignal.  I wonder if Fsignal resets other things that might 
>> not
>> add up in the interim period but I don't know what the rules are for placing
>> the QUIT macro or whether one could be placed closer to read_char.
>
> I don't follow this argument.  
>
> Since the purpose of setting waiting_for_input is for emacs to produce
> C-g, it depends on the key binding whether Fsignal is ever called.

There is no situation on a tty or on any platform where this is done
by signal directly?  And it does not depend on SYNC_INPUT?

While I have no clue about the situation, those are two keywords that
pop up in my head.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum